[Asterisk-code-review] res pjsip: Add serialized scheduler (res pjsip/pjsip schedu... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Add serialized scheduler (res_pjsip/pjsip_scheduler.c)
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I didn't look at the whole patch.  Just the initial reaction to the ao2_is_object_valid().

https://gerrit.asterisk.org/#/c/2443/3/main/astobj2.c
File main/astobj2.c:

Line 140: int ao2_is_object_valid(void *user_data)
This is not a safe function if user_data was never supposed to be an ao2 object.  It looks outside of valid memory.  A seg fault in the making.  Not to mention that the random value it may find there might actually be a magic number even though it isn't a magic number.


-- 
To view, visit https://gerrit.asterisk.org/2443
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7af6ad2b2d896ea68e478aa1ae201d6dd016ba1c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes