[Asterisk-code-review] res pjsip mwi: Add voicemail extension and mwi subscribe re... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip_mwi:  Add voicemail extension and mwi_subscribe_replaces_unsolicited
......................................................................


Patch Set 5:

(3 comments)

> (3 comments)
 > 
 > I'm not 100% sure on this, but with regards to the
 > mwi_subscribe_replaces_unsolicited option, would there be value in
 > automatically renewing unsolicited MWI if the subscription is
 > terminated?

Based on what I understand from Ross, it just confuses the clients because they're not expecting it.  They SHOULD be able to handle it but I guess some handle it better than others.  If someone has a case for restarting unsolicited we can easily add it later.

https://gerrit.asterisk.org/#/c/2464/5/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

Line 632: ;mwi_subscribe_replaces_unsolicited=no
> I know you don't have a master version of this up, but I'd be fine with mas
Agreed. Will do in the master version.


https://gerrit.asterisk.org/#/c/2464/5/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 313: 	/* Voicemail extension to set in Message-Account */
        : 	char *voicemail_extension;
> Seems like this should just be added to the AST_STRING_FIELDs earlier in th
Would break ABI


Line 471: 	/* Voicemail extension to set in Message-Account */
        : 	char *voicemail_extension;
> Same here. Just add this to the string fields already on this structure.
Would break ABI


-- 
To view, visit https://gerrit.asterisk.org/2464
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15a9415091760539c7134a5ba3dc4a6a1217cea
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes