[Asterisk-code-review] res pjsip mwi: Add voicemail extension and mwi subscribe re... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Mar 25 11:27:55 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_mwi:  Add voicemail extension and mwi_subscribe_replaces_unsolicited
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/2464/4/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 829: 		if (aor && dlg && sip_uri) {
        : 			set_voicemail_extension(dlg->pool, sip_uri, counter, aor->voicemail_extension);
        : 		}
        : 		ao2_cleanup(aor);
aor is never going to be NULL at this point because you have already checked.


-- 
To view, visit https://gerrit.asterisk.org/2464
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15a9415091760539c7134a5ba3dc4a6a1217cea
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list