[Asterisk-code-review] app echo: forward and generate VIDUPDATE frames (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_echo: forward and generate VIDUPDATE frames
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

This patch will need to be cherry-picked to master

https://gerrit.asterisk.org/#/c/2467/1//COMMIT_MSG
Commit Message:

Line 19: ASTERISK-25867
Add
#close
to the end of this line since this patch fixes the issue.


https://gerrit.asterisk.org/#/c/2467/1/apps/app_echo.c
File apps/app_echo.c:

Line 70: 		if (f->frametype == AST_FRAME_CONTROL && f->subclass.integer == AST_CONTROL_VIDUPDATE
Add line breaks for better readability.

if (f->frametype == control
    && f->subclass == xxx


Line 73: 			fir_sent = 1;
This flag is not going to be set when you intended.  It will get set here only if the ast_write() fails.


Line 77: 			struct ast_frame frame = { .frametype = AST_FRAME_CONTROL, .subclass.integer = AST_CONTROL_VIDUPDATE };
format this way:
struct ast_frame frame = {
   .frametype = xxx,
   .subclass.integer = yyy,
};


-- 
To view, visit https://gerrit.asterisk.org/2467
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73bda87bf7532ee8bfb28d917045a21034908c1e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Jacek Konieczny <jkonieczny at eggsoft.pl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes