[Asterisk-code-review] res pjsip mwi: Add voicemail extension and mwi subscribe re... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip_mwi:  Add voicemail extension and mwi_subscribe_replaces_unsolicited
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.asterisk.org/#/c/2464/3//COMMIT_MSG
Commit Message:

Line 11: on endpoints for unsolicitged mwi and on aors for subscriptions required
> s/uncolicitged/unsolicited/
Done


https://gerrit.asterisk.org/#/c/2464/3/include/asterisk/res_pjsip_pubsub.h
File include/asterisk/res_pjsip_pubsub.h:

Line 344:  * \since 13.8.0
> v13.8.0 has a release candidate so these and others in this review need to 
Done


https://gerrit.asterisk.org/#/c/2464/3/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 380: 		ast_free(body_text);
> Delete the free because body_text is uninitialized at this point.
copy/paste, was below.


Line 504: 			ao2_ref(aor, -1);
> aor is ref leaked.  This needs to always be done if aor is not NULL.
Oops, the if used to just check for aor.


Line 831: 			ao2_ref(aor, -1);
> same ref leak about aor here
same reason.


-- 
To view, visit https://gerrit.asterisk.org/2464
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15a9415091760539c7134a5ba3dc4a6a1217cea
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes