[Asterisk-code-review] tests/test http media cache: Add unit tests for res http med... (asterisk[master])

Badalian Vyacheslav asteriskteam at digium.com
Thu Mar 24 05:20:09 CDT 2016


Badalian Vyacheslav has posted comments on this change.

Change subject: tests/test_http_media_cache: Add unit tests for res_http_media_cache
......................................................................


Patch Set 6:

(5 comments)

i think must be like that.

https://gerrit.asterisk.org/#/c/1891/6/tests/test_http_media_cache.c
File tests/test_http_media_cache.c:

Line 176: 		if (send_file) {
-


Line 177: 			close(fd);
-


Line 178: 		}
-


Line 182: 		unlink(file_name);
+ close(fd);


Line 186: 
+ ast_free(http_header);


-- 
To view, visit https://gerrit.asterisk.org/1891
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2db101e307c863857fe416d6f5bf4cace9ac7cf5
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list