[Asterisk-code-review] cdr adaptive odbc: Prevent not logger when is load before th... (asterisk[master])

[Michael L. Young]

Michael L. Young has posted comments on this change.

Change subject: cdr_adaptive_odbc: Prevent not logger when is load before than database.
......................................................................


Patch Set 1:

> Hi Michael and Joshua,
 > 
 > The problem is when the database ran after the Asterisk.
 > 
 > The other modules like odbc_res is loaded.
 > 
 > cdr_adaptive_odbc is loaded but dont have information about the
 > fields to will do log.
 > 
 > What other way we can resolve this?
 
Okay.  So, the database server is not running when starting Asterisk?  Since having the database running at the load time of this module really is required for it to do its job of being "adaptive", the module should not be in a running state, which is what the current behavior is if I am understanding things correctly.

This sounds more like a system administration issue if your database server is not running at the time that Asterisk is started up.  In a cluster setup, you would be checking that the database server is running before starting up Asterisk.

Should we possibly present this to the dev community to get feedback on whether we want Asterisk reloading a module automatically?  I am not sure if there are any modules within Asterisk that currently behave in the manner that your patch is proposing.  Not sure how people feel about a module automatically reloading itself.  This may pose problems for those on a busy system having a module continually trying to reload itself while the database server is still down.

-- 
To view, visit https://gerrit.asterisk.org/2363
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3569e29d26357055f440abf70f790cd12e874bf
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: No