[Asterisk-code-review] chan sip.c: Space after port causes unnecessary resolution a... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Mar 22 10:29:32 CDT 2016


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2446

to look at the new patch set (#3).

Change subject: chan_sip.c: Space after port causes unnecessary resolution attempt
......................................................................

chan_sip.c: Space after port causes unnecessary resolution attempt

check_via() already skips leading blanks where the sent-by address (with the
optional port) should be placed.

Since RFC 3261 allows for blanks between the port ant the Via parameters:
> https://tools.ietf.org/html/rfc3261#section-20.42
(actually it allows a lot of blanks more ;-)). I just switched from
ast_skip_blanks() to ast_strip() on the local copy of the string.

ASTERISK-21301 #close

Change-Id: Ie5b8fe5a07067b7c0dc9bcdd1707e99b23b02b06
---
M channels/chan_sip.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/46/2446/3
-- 
To view, visit https://gerrit.asterisk.org/2446
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie5b8fe5a07067b7c0dc9bcdd1707e99b23b02b06
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Francesco Castellano <francesco.castellano at messagenet.it>
Gerrit-Reviewer: Anonymous Coward #1000019



More information about the asterisk-code-review mailing list