[Asterisk-code-review] chan pjsip: ref leak when checking direct media glare (asterisk[13])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: chan_pjsip: ref leak when checking direct_media_glare
......................................................................


chan_pjsip: ref leak when checking direct_media_glare

Fix the reference leak introduced in the following commit:

9444ddadf8525d1ce66a1faf1db97f9f6c265ca4

ASTERISK-25849

Change-Id: I5cfefd5ee6c1c3a1715c050330aaa10e4d2a5e85
---
M channels/chan_pjsip.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  Matthew Fredrickson: Looks good to me, but someone else must approve



diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 16f0426..07887af 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -348,6 +348,7 @@
 
 	if (direct_media_mitigate_glare(cdata->session)) {
 		ast_debug(4, "Disregarding setting RTP on %s: mitigating re-INVITE glare\n", ast_channel_name(cdata->chan));
+		ao2_ref(cdata, -1);
 		return 0;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/2436
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cfefd5ee6c1c3a1715c050330aaa10e4d2a5e85
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>