[Asterisk-code-review] app voicemail: always copy dynamic struct to avoid race cond... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: app_voicemail: always copy dynamic struct to avoid race condition
......................................................................


Patch Set 3:

>Kevin, would adding free_user to those off nominal paths help with the memory leak or will this require more thought?
>I take that back I dont think it will some of the paths are very complex

Heh yeah it's a bit of a mess. I didn't look too close, but I suspect adding ast_free before any return paths should fix any leaks.

-- 
To view, visit https://gerrit.asterisk.org/2433
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0643813116da84e2617291903d0d489b7425fb
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No