[Asterisk-code-review] sorcery/res pjsip: Refactor for realtime performance (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: sorcery/res_pjsip:  Refactor for realtime performance
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

Minor comment.

https://gerrit.asterisk.org/#/c/2370/10/include/asterisk/sorcery.h
File include/asterisk/sorcery.h:

Line 1164:  *       of the given type. (this flag is currently ignored)
Remove the "this flag is currently ignored". While stuff ignores it this gives the impression the flag does nothing and shouldn't be used - which is not entirely true. If you are retrieving all you should use this flag, one day it may be needed.


-- 
To view, visit https://gerrit.asterisk.org/2370
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2691e447db90892890036e663aaf907b2dc1c67
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes