[Asterisk-code-review] chan sip.c: Fix session timers deadlock potential. (asterisk[master])

[Richard Mudgett]

Hello Anonymous Coward #1000019, Joshua Colp, George Joseph,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2410

to look at the new patch set (#2).

Change subject: chan_sip.c: Fix session timers deadlock potential.
......................................................................

chan_sip.c: Fix session timers deadlock potential.

This patch is part of a series to resolve deadlocks in chan_sip.c.

Stopping a scheduled event can result in a deadlock if the scheduled event
is running when you try to stop the event.  If you hold a lock needed by
the scheduled event while trying to stop the scheduled event then a
deadlock can happen.  The general strategy for resolving the deadlock
potential is to push the actual starting and stopping of the scheduled
events off onto the scheduler/do_monitor() thread by scheduling an
immediate one shot scheduled event.  Some restructuring may be needed
because the code may assume that the start/stop of the scheduled events is
immediate.

ASTERISK-25023

Change-Id: I6d65269151ba95e0d8fe4e9e611881cde2ab4900
---
M channels/chan_sip.c
M channels/sip/include/sip.h
2 files changed, 132 insertions(+), 114 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/2410/2
-- 
To view, visit https://gerrit.asterisk.org/2410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d65269151ba95e0d8fe4e9e611881cde2ab4900
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>