[Asterisk-code-review] app stasis: Don't hang up if app not registered (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_stasis: Don't hang up if app not registered
......................................................................


Patch Set 5:

(3 comments)

Very minor issues.  Then it needs to be cherry-picked to master.

https://gerrit.asterisk.org/#/c/2402/5//COMMIT_MSG
Commit Message:

Line 9: This prevents pbx_core from hanging up the channel if the app isnt
s/isnt/isn't/


https://gerrit.asterisk.org/#/c/2402/5/apps/app_stasis.c
File apps/app_stasis.c:

Line 115: 		if(!ast_check_hangup(chan)) {
Guidelines: Space after if: if () {}


Line 118: 			ret = 1;
The channel has hung up or has been blind transferred so you need to return -1.  Returning 1 is going to attempt to execute the e exten on a hung up or blind transferred channel which is not desired.


-- 
To view, visit https://gerrit.asterisk.org/2402
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63216a61f30706d5362bc0906b50b6f0544aebce
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes