[Asterisk-code-review] sorcery/res pjsip: Refactor for realtime performance (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: sorcery/res_pjsip:  Refactor for realtime performance
......................................................................


Patch Set 9:

(4 comments)

My review is not thorough since I had to leave, but I've got some concerns with a few places.

https://gerrit.asterisk.org/#/c/2370/9/main/strings.c
File main/strings.c:

Line 250: 		if (right[0] == '/' && right[strlen(left) - 1] == '/') {
Was this supposed to be strlen(right)? Seems like you'll fall into some badness if left is zero-length or longer than right.


Line 252: 			internal_right = ast_strdupa(left);
Again, not sure if this was supposed to be ast_strdupa(right) here.


Line 280: 			/* fall thgouth to regex */
Most amusing misspelling of "through" I've seen in a while.


Line 284: regex:
Instead of gotos and labels, why not use functions?


-- 
To view, visit https://gerrit.asterisk.org/2370
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2691e447db90892890036e663aaf907b2dc1c67
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes