[Asterisk-code-review] sorcery/res pjsip: Refactor for realtime performance (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: sorcery/res_pjsip:  Refactor for realtime performance
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.asterisk.org/#/c/2370/8/include/asterisk/sorcery.h
File include/asterisk/sorcery.h:

Line 1164:  *       of the given type. (this flag is currently ignored)
> AST_RETRIEVE_FLAG_ALL isn't actually used in ast_sorcery_retrieve_by_fields
Ah, that's because it's to convey intent in case a backend wizard needs to do anything special. Generally the way they're written it doesn't need any explicit logic.


-- 
To view, visit https://gerrit.asterisk.org/2370
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2691e447db90892890036e663aaf907b2dc1c67
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes