[Asterisk-code-review] pjproject: Pass (dont )optimize flags to pjproject and fix ... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: pjproject:  Pass (dont_)optimize flags to pjproject and fix pjsua
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2378/1/third-party/pjproject/Makefile.rules
File third-party/pjproject/Makefile.rules:

Line 5: 	--with-external-pa --disable-video --disable-v4l2 --disable-sound \
The ever changing options to configure here are resulting in the dependencies for this changing. I'm afraid that we're never going to find the right combination for everything and the resulting dependency requirements are going to be unwieldy for users. Can we use the results of our own configure to construct an appropriate list of options based on what is actually available?


-- 
To view, visit https://gerrit.asterisk.org/2378
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b0a4d0872acef00ed89b3c527a713ee4c2ccd4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes