[Asterisk-code-review] Restrict CLI/AMI commands on shutdown. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Mon Mar 14 10:15:37 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: Restrict CLI/AMI commands on shutdown.
......................................................................


Patch Set 3: Code-Review-1

This doesn't appear to remove the entry from the vector on an unregister, is this on purpose? I realize right now the CLI commands allowed would never be unregistered but if this changes then you've got an old CLI entry in the vector (which won't crash but if you the memory is reused for another CLI entry then may cause problems... a stretch mind you)

-- 
To view, visit https://gerrit.asterisk.org/2372
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8887e215ac352fadf7f4c1e082da9089b1421990
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list