[Asterisk-code-review] build system: Split COMPILE DOUBLE from DONT OPTIMIZE (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: build_system:  Split COMPILE_DOUBLE from DONT_OPTIMIZE
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > Well, turning both DONT_OPTIMIZE and COMPILE_DOUBLE on restores the
 > original behavior.  Were people really submitting patches without
 > testing without DONT_OPTIMIZE?  (There's a double negative for you)

Yes it did happen.  Would you normally expect more diagnostics when optimization is turned on than when it is turned off?  That is why it was created in the first place to ensure that all diagnostic messages were caught.

 > 
 > I suppose I could set DONT_OPTIMIZE to automatically turn on
 > COMPILE_DOUBLE and make you unselect it if you don't want it.
 > Would you be OK with that?

Yes.  With it defaulting to COMPILE_DOUBLE, the continuous integration should automatically catch any additional issues before it gets committed.

-- 
To view, visit https://gerrit.asterisk.org/2380
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49ca930ac4b5ec4fc2d8141979ad888da7b1611
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No