[Asterisk-code-review] build system: Split COMPILE DOUBLE from DONT OPTIMIZE (asterisk[13])

George Joseph asteriskteam at digium.com
Sat Mar 12 18:15:04 CST 2016


George Joseph has posted comments on this change.

Change subject: build_system:  Split COMPILE_DOUBLE from DONT_OPTIMIZE
......................................................................


Patch Set 1:

(1 comment)

Well, turning both DONT_OPTIMIZE and COMPILE_DOUBLE on restores the original behavior.  Were people really submitting patches without testing without DONT_OPTIMIZE?  (There's a double negative for you)

I suppose I could set DONT_OPTIMIZE to automatically turn on COMPILE_DOUBLE and make you unselect it if you don't want it.
Would you be OK with that?

https://gerrit.asterisk.org/#/c/2380/1//COMMIT_MSG
Commit Message:

Line 9: I can't ever recall actually needed the intermediate files or
> s/needed/needing/
Just for you. :)


-- 
To view, visit https://gerrit.asterisk.org/2380
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49ca930ac4b5ec4fc2d8141979ad888da7b1611
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list