[Asterisk-code-review] build system: Split COMPILE DOUBLE from DONT OPTIMIZE (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: build_system:  Split COMPILE_DOUBLE from DONT_OPTIMIZE
......................................................................


Patch Set 1:

(1 comment)

I don't think this patch is a good thing to do.

The purpose of the extra compile is that gcc has more compile time diagnostic checks when optimizing.  What was happening when the double compilation feature got created was people were checking in patches that failed to compile in developer mode when optimization was turned on.

https://gerrit.asterisk.org/#/c/2380/1//COMMIT_MSG
Commit Message:

Line 9: I can't ever recall actually needed the intermediate files or
s/needed/needing/


-- 
To view, visit https://gerrit.asterisk.org/2380
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49ca930ac4b5ec4fc2d8141979ad888da7b1611
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes