[Asterisk-code-review] SIP/sip custom presence/resubscribe fails due to retransmiss... (testsuite[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: SIP/sip_custom_presence/resubscribe fails due to retransmission(s)
......................................................................


SIP/sip_custom_presence/resubscribe fails due to retransmission(s)

Sporadically, Asterisk takes a little longer than usual to send the 200 OK reply
for the subscribe. When this happens SIPp restransmits the subscribe, however in
this time Asterisk responds to the first subscribe, receives the retransmit and
responds to it as well. The SIPp scenario of course was not expecting another
200 OK response, so fails.

This patch disables retransmits in the test's SIPp scenarios. Asterisk should
always be up and running by the time the scenario starts so should either always
respond at some point or fail altogether.

Change-Id: Ibea55d4cd35d378196e3680e84fc2a537dddf296
---
M tests/channels/SIP/sip_custom_presence/resubscribe/run-test
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve



diff --git a/tests/channels/SIP/sip_custom_presence/resubscribe/run-test b/tests/channels/SIP/sip_custom_presence/resubscribe/run-test
index 1ddd8ec..ab4288f 100755
--- a/tests/channels/SIP/sip_custom_presence/resubscribe/run-test
+++ b/tests/channels/SIP/sip_custom_presence/resubscribe/run-test
@@ -36,8 +36,8 @@
     def __init__(self):
         TestCase.__init__(self)
         self.create_asterisk()
-        self.sipTestInitial = SIPpScenario(TEST_DIR, SIPP_SCENARIO_INITIAL)
-        self.sipTestResubscribe = SIPpScenario(TEST_DIR, SIPP_SCENARIO_RESUBSCRIBE)
+        self.sipTestInitial = SIPpScenario(TEST_DIR, SIPP_SCENARIO_INITIAL, ['-nr'])
+        self.sipTestResubscribe = SIPpScenario(TEST_DIR, SIPP_SCENARIO_RESUBSCRIBE, ['-nr'])
         self.sippPassed = False
         self.notifyPassed = False
         self.num_notifies = 0

-- 
To view, visit https://gerrit.asterisk.org/2364
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea55d4cd35d378196e3680e84fc2a537dddf296
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>