[Asterisk-code-review] res pjsip: Strip spaces from items parsed from comma-separa... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Strip spaces from items parsed from comma-separated lists
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2358/3/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 937: 		if (ast_strlen_zero(mailbox)) {
        : 			continue;
        : 		}
Sub is leaked if !aggregate_sub

if (ast_strlen_zero(mailbox)) {
  if (!aggregate_sub) {
     ao2_cleanup(sub);
  }
  continue;
}


Actually it is better if the mailbox is checked before sub is even assigned.  Less memory allocation involved.


-- 
To view, visit https://gerrit.asterisk.org/2358
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b22a2cf22a7c1c50d4ecacbfa540155bec0e7a2
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes