[Asterisk-code-review] res pjsip: Strip spaces from items parsed from comma-separa... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Strip spaces from items parsed from comma-separated lists
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/2359/2/include/asterisk/strings.h
File include/asterisk/strings.h:

Line 148: 	while (str && *str && ((unsigned char) *str) < 33)
        : 		str++;
if (str) {
  while () {
  }
}


Line 187: 	while (str && *str && ((unsigned char) *str) > 32)
        : 		str++;
if (str) {
  while () {
  }
}


Line 205: 	if (s && (s = ast_skip_blanks(s))) {
This change isn't necessary because of the change to make ast_skip_blanks() null tolerant.


https://gerrit.asterisk.org/#/c/2359/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 480: 	while ((val = ast_strip(strsep(&idents, ",")))) {
        : 		if (!strcasecmp(val, "username")) {
Should add the ast_strlen_zero() check like other places.


-- 
To view, visit https://gerrit.asterisk.org/2359
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b22a2cf22a7c1c50d4ecacbfa540155bec0e7a2
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes