[Asterisk-code-review] main/cli.c: Refactor function to print seconds formatted (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: main/cli.c: Refactor function to print seconds formatted
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

Minor nits but I'll +1 it anyway

https://gerrit.asterisk.org/#/c/2272/5/cdr/cdr_pgsql.c
File cdr/cdr_pgsql.c:

Line 143: 		char status2[100] = "" ;
Extra space before semicolon.


https://gerrit.asterisk.org/#/c/2272/5/main/cli.c
File main/cli.c:

Line 2752: 	print_uptimestr(fd, ast_tv(seconds, 0),  prefix, 0);
extra space before prefix parameter


https://gerrit.asterisk.org/#/c/2272/5/res/res_config_pgsql.c
File res/res_config_pgsql.c:

Line 1606: 	snprintf(buf, sizeof(buf), "Connected to %s%s for ", connection_info, credentials);
This could be moved to just before ast_cli_print_timestr_fromseconds() since buf is only used there.


-- 
To view, visit https://gerrit.asterisk.org/2272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb8634102cd11d3f8623398b279cb731bcde36c
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes