[Asterisk-code-review] res pjsip: Add " " as a separator in comma-separated parame... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Add " " as a separator in comma-separated parameter lists
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2358/1/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

Line 823: 		RAII_VAR(struct ast_sip_aor *, aor, ast_sip_location_retrieve_aor(aor_name), ao2_cleanup);
Use ast_strip(aor_name) instead here.  This will fix the extra spaces issue without making spaces a delimiter.


https://gerrit.asterisk.org/#/c/2358/1/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

Line 988: 	while ((name = strtok_r(NULL, ", ", &parse))) {
        : 		name = ast_strip(name);
This was not affected because ast_strip() removes any spaces.  In fact, using ast_strip() is the way the issue should be fixed.


-- 
To view, visit https://gerrit.asterisk.org/2358
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b22a2cf22a7c1c50d4ecacbfa540155bec0e7a2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes