[Asterisk-code-review] blind transfers: Notify with sip frag 100 now arrives later (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Fri Mar 4 11:22:40 CST 2016


Kevin Harwell has uploaded a new change for review.

  https://gerrit.asterisk.org/2354

Change subject: blind transfers: Notify with sip frag 100 now arrives later
......................................................................

blind transfers: Notify with sip frag 100 now arrives later

Some phones send a hang up immediately after receiving the first sip notify
during a transfer. Because of this asterisk was modified to delay sending the
initial notify that contains a sip frag 100 to a bit later.

A couple of pjsip transfer tests, blind_transfer/callee_direct_media and
blind_transfer/caller_direct_media, have been changed to account for the
late arrival of the notify.

ASTERISK-25771

Change-Id: I8a0be41a3a19015c6b69e20e38f2853e2defd8dd
---
M tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml
M tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml
2 files changed, 38 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/54/2354/1

diff --git a/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml b/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml
index 35cf649..fc3716a 100644
--- a/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml
+++ b/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml
@@ -123,25 +123,6 @@
   <recv response="202" rtd="true">
   </recv>
 
-  <!-- We should receive a NOTIFY from Asterisk with a 100 trying sipfrag -->
-  <recv request="NOTIFY" crlf="true">
-  </recv>
-
-  <send>
-    <![CDATA[
-
-      SIP/2.0 200 OK
-      [last_Via:]
-      [last_From:]
-      [last_To:]
-      [last_Call-ID:]
-      [last_CSeq:]
-      [last_Event:]
-      Contact: <sip:[local_ip]:[local_port];transport=[transport]>
-      Content-Length: 0
-    ]]>
-  </send>
-
   <!--
        Wait for re-invite for tearing down direct media between alice and bob
        due to transfering alice to charlie.
@@ -182,6 +163,25 @@
 
   <label id="12" />
 
+  <!-- We should receive a NOTIFY from Asterisk with a 100 trying sipfrag -->
+  <recv request="NOTIFY" crlf="true">
+  </recv>
+
+  <send>
+    <![CDATA[
+
+      SIP/2.0 200 OK
+      [last_Via:]
+      [last_From:]
+      [last_To:]
+      [last_Call-ID:]
+      [last_CSeq:]
+      [last_Event:]
+      Contact: <sip:[local_ip]:[local_port];transport=[transport]>
+      Content-Length: 0
+    ]]>
+  </send>
+
   <!-- We should receive a NOTIFY from Asterisk with a '200 OK' sipfrag -->
   <recv request="NOTIFY" crlf="true" next="13">
     <!-- Check if 'SIP/2.0 200 OK' is in the body -->
diff --git a/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml b/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml
index bca2c85..f9867f9 100644
--- a/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml
+++ b/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml
@@ -123,25 +123,6 @@
   <recv response="202" rtd="true">
   </recv>
 
-  <!-- We should receive a NOTIFY from Asterisk with a 100 trying sipfrag -->
-  <recv request="NOTIFY" crlf="true">
-  </recv>
-
-  <send>
-    <![CDATA[
-
-      SIP/2.0 200 OK
-      [last_Via:]
-      [last_From:]
-      [last_To:]
-      [last_Call-ID:]
-      [last_CSeq:]
-      [last_Event:]
-      Contact: <sip:[local_ip]:[local_port];transport=[transport]>
-      Content-Length: 0
-    ]]>
-  </send>
-
   <!--
        Wait for re-invite for tearing down direct media between alice and bob
        due to transfering bob to charlie.
@@ -177,6 +158,25 @@
     crlf="true">
   </recv>
 
+  <!-- We should receive a NOTIFY from Asterisk with a 100 trying sipfrag -->
+  <recv request="NOTIFY" crlf="true">
+  </recv>
+
+  <send>
+    <![CDATA[
+
+      SIP/2.0 200 OK
+      [last_Via:]
+      [last_From:]
+      [last_To:]
+      [last_Call-ID:]
+      [last_CSeq:]
+      [last_Event:]
+      Contact: <sip:[local_ip]:[local_port];transport=[transport]>
+      Content-Length: 0
+    ]]>
+  </send>
+
   <!-- We should receive a NOTIFY from Asterisk with a '200 OK' sipfrag -->
   <recv request="NOTIFY" crlf="true">
     <!-- Check if 'SIP/2.0 200 OK' is in the body -->

-- 
To view, visit https://gerrit.asterisk.org/2354
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a0be41a3a19015c6b69e20e38f2853e2defd8dd
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list