[Asterisk-code-review] loader: Retry dlopen when loading fails (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: loader: Retry dlopen when loading fails
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

Minor nits other than the memory leak.

https://gerrit.asterisk.org/#/c/2073/6/main/loader.c
File main/loader.c:

Line 1206: 		enum ast_module_load_result lres;
         : 		/* Suppress log messages unless this is the last pass */
Please add a blank line after the declaration.  It makes declarations stand out from code better.


Line 1244: 			enum ast_module_load_result lres;
         : 			/* Suppress log messages unless this is the last pass */
Please add a blank line after the declaration.  It makes declarations stand out from code better.


Line 1283: 	while ((order = AST_LIST_REMOVE_HEAD(&load_retries, entry))) {
         : 		ast_free(order->resource);
         : 		ast_free(order);
         : 	}
         : 
This code should be moved to the done label.  Otherwise, the list members could be leaked on an AST_MODULE_LOAD_FAILURE.


Line 1290: 		enum ast_module_load_result lres;
         : 		lres = start_resource(mod);
Please add a blank line after the declaration.  It makes declarations stand out from code better.


-- 
To view, visit https://gerrit.asterisk.org/2073
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddae1d97cd2f00b94e61662447432765755f64bb
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes