[Asterisk-code-review] testsuite: Cleanup tests/channels/SIP/redirecting reason (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Thu Mar 3 07:18:41 CST 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: testsuite: Cleanup tests/channels/SIP/redirecting_reason
......................................................................


testsuite: Cleanup tests/channels/SIP/redirecting_reason

* Add debug dialplan lines.
* Add more test dependencies.

Change-Id: I94a41747642f61cbb1b02a1d8ec68b93a70bd9dd
---
M tests/channels/SIP/redirecting_reason/configs/ast1/extensions.conf
M tests/channels/SIP/redirecting_reason/test-config.yaml
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/SIP/redirecting_reason/configs/ast1/extensions.conf b/tests/channels/SIP/redirecting_reason/configs/ast1/extensions.conf
index 11c4fe2..1a4434f 100644
--- a/tests/channels/SIP/redirecting_reason/configs/ast1/extensions.conf
+++ b/tests/channels/SIP/redirecting_reason/configs/ast1/extensions.conf
@@ -4,10 +4,12 @@
 same => n,Hangup
 
 exten => test_diversion,1,Answer
+same => n,NoOp(REDIRECTING(reason) is '${REDIRECTING(reason)}')
 same => n,UserEvent(RedirectReason, Result: ${IF($[${REDIRECTING(reason)} = eggdog]?Success:Failure)})
 same => n,Hangup()
 
 exten => unavailable,1,Dial(SIP/diverter)
+same => n,NoOp(REDIRECTING(reason) is '${REDIRECTING(reason)}')
 same => n,UserEvent(RedirectReason, Result: ${IF($[${REDIRECTING(reason)} = eggdog]?Success:Failure)})
 same => n,Answer()
 same => n,Hangup()
diff --git a/tests/channels/SIP/redirecting_reason/test-config.yaml b/tests/channels/SIP/redirecting_reason/test-config.yaml
index f9d4ddc..1e5ab87 100644
--- a/tests/channels/SIP/redirecting_reason/test-config.yaml
+++ b/tests/channels/SIP/redirecting_reason/test-config.yaml
@@ -54,9 +54,13 @@
 properties:
     minversion: '13.0.0'
     dependencies:
+        - python: 'twisted'
         - python: 'starpy'
         - sipp:
             version: 'v3.1'
+        - asterisk: 'app_dial'
+        - asterisk: 'app_userevent'
         - asterisk: 'chan_sip'
+        - asterisk: 'func_callerid'
     tags:
         - SIP

-- 
To view, visit https://gerrit.asterisk.org/2336
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94a41747642f61cbb1b02a1d8ec68b93a70bd9dd
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list