[Asterisk-code-review] loader: Retry dlopen when loading fails (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: loader: Retry dlopen when loading fails
......................................................................


Patch Set 6:

(2 comments)

Admittedly, I am not too familiar with some of this, so I could be way off in left field here with some or all of my questions.

https://gerrit.asterisk.org/#/c/2073/6/main/loader.c
File main/loader.c:

Line 554: 	if (!(lib = dlopen(fn, RTLD_LAZY | RTLD_GLOBAL))) {
Why this change to RTLD_GLOBAL? Should this be the case only for global type modules? Could this allow a subsequent module to potentially overwrite symbols when it shouldn't?


Line 1250: 			case AST_MODULE_LOAD_SUCCESS:
If it was successfully loaded shouldn't it be removed from the retry list?


-- 
To view, visit https://gerrit.asterisk.org/2073
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddae1d97cd2f00b94e61662447432765755f64bb
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes