[Asterisk-code-review] res pjsip refer.c: Delay sending the initial SIP Notify with... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_refer.c: Delay sending the initial SIP Notify with frag 100
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Minor nits

https://gerrit.asterisk.org/#/c/2321/1//COMMIT_MSG
Commit Message:

Line 17: If the transferer gets hung
       : up early, then leaves the bridge the local channel fails to find it when
       : looking it up
Awkward sentence


https://gerrit.asterisk.org/#/c/2321/1/res/res_pjsip_refer.c
File res/res_pjsip_refer.c:

Line 62: 	/*! \brief Flag indicating if the 100 notify has been sent */
s/Flag indicating/non-zero/


Line 138: 	/*
        : 	 * If a notify with sip frag 100 has not been sent then send that first. If it fails
        : 	 * for some reason we'll just continue as if it was sent.
        : 	 */
How about this:

Send a deferred initial 100 Trying SIP frag NOTIFY if we haven't already.


Line 145: 			ast_debug(3, "Sending initial 100 Trying NOTIFY for progress monitor '%p'\n", notification->progress);
nit: break long line.  Suggest break after the format string.


-- 
To view, visit https://gerrit.asterisk.org/2321
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09cfc9a5d6ed4c007bc70625e0972b470393bf16
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes