[Asterisk-code-review] alembic: Fix downgrade and tweak for sqlite (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: alembic: Fix downgrade and tweak for sqlite
......................................................................


Patch Set 1: Code-Review-1

(16 comments)

Found a few places with whitespace.

I also marked the superfluous "pass" keywords that were left in some of the files, but if you don't want to mess with removing them then feel free to  ignore them since they are not actually hurting anything.

https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/3bcc0b5bc2c9_add_allow_reload_to_ps_transports.py
File contrib/ast-db-manage/config/versions/3bcc0b5bc2c9_add_allow_reload_to_ps_transports.py:

Line 23:     pass
While you are making changes the "pass" can be dropped


Line 28:     pass
Another one to drop


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/423f34ad36e2_fix_pjsip_qualify_ti.py
File contrib/ast-db-manage/config/versions/423f34ad36e2_fix_pjsip_qualify_ti.py:

Line 22:     pass
Another "pass" that could be dropped


Line 30:     pass
remove "pass"


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py
File contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py:

Line 186:     
Extra space/tab/red blob


Line 201:         for e in enums:    
Another red blob


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/461d7d691209_add_pjsip_qualify_timeout.py
File contrib/ast-db-manage/config/versions/461d7d691209_add_pjsip_qualify_timeout.py:

Line 19:     pass
Can remove the "pass"


Line 27:     pass
Found another "pass" that could be removed.


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
File contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py:

Line 40:         
More whitespace


Line 41:     pass
extra "pass"


Line 65:     pass
another "pass"


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py
File contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:

Line 327:     
Whitespace


Line 333:     
        :     
red blobs


Line 342:         for e in enums:    
Another whitespace


https://gerrit.asterisk.org/#/c/2328/1/contrib/ast-db-manage/config/versions/dbc44d5a908_add_missing_columns_to_sys_and_reg.py
File contrib/ast-db-manage/config/versions/dbc44d5a908_add_missing_columns_to_sys_and_reg.py:

Line 30:     pass
Another "pass" if removing them


Line 39:     pass
"pass" again


-- 
To view, visit https://gerrit.asterisk.org/2328
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I862b0739eb3fd45ec3412dcc13c2340e1b7baef8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes