[Asterisk-code-review] CHAOS: prevent crash on failed strdup (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Wed Mar 2 09:41:31 CST 2016


Kevin Harwell has posted comments on this change.

Change subject: CHAOS: prevent crash on failed strdup
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2340/1/res/res_pjsip_messaging.c
File res/res_pjsip_messaging.c:

Line 531: 	mdata->to = ast_begins_with(to, "sip:") ? ast_strdup(++to) : ast_strdup(to - 3);
Probably want to go ahead and have a check for the "to" field as well.


-- 
To view, visit https://gerrit.asterisk.org/2340
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f67434820ba53b53663efd6cbb42749f4f6c0f5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list