[Asterisk-code-review] testsuite: Cleanup tests/channels/pjsip/refer send to vm (testsuite[master])

[Richard Mudgett]

Richard Mudgett has uploaded a new change for review.

  https://gerrit.asterisk.org/2333

Change subject: testsuite: Cleanup tests/channels/pjsip/refer_send_to_vm
......................................................................

testsuite: Cleanup tests/channels/pjsip/refer_send_to_vm

* Add debug dialplan lines.
* Made dialplan validate both REDIRECTING(reason) and the special
SIP header values.
* Add more test dependencies.

Change-Id: I4b113c33a1727851bfa6181b63018a4461904160
---
M tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf
M tests/channels/pjsip/refer_send_to_vm/test-config.yaml
2 files changed, 13 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/33/2333/1

diff --git a/tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf b/tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf
index 1b639dc..771d899 100644
--- a/tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf
+++ b/tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf
@@ -6,7 +6,9 @@
       same => n,Hangup()
 
 exten => carol,1,NoOp()
-      same => n,GotoIf($[${REDIRECTING(reason)} = "send_to_vm" | "${PJSIP_HEADER(read,X-Digium-Call-Feature)}" = "feature_send_to_vm"]?vm:notvm)
+      same => n,NoOp(REDIRECTING(reason) is '${REDIRECTING(reason)}')
+      same => n,NoOp(PJSIP_HEADER(read,X-Digium-Call-Feature) is '${PJSIP_HEADER(read,X-Digium-Call-Feature)}')
+      same => n,GotoIf($[${REDIRECTING(reason)} = "send_to_vm" & "${PJSIP_HEADER(read,X-Digium-Call-Feature)}" = "feature_send_to_vm"]?vm:notvm)
       same => n(vm),UserEvent(Result, Status: passed)
       same => n,Hangup()
       same => n(notvm),UserEvent(Result, Status: failed)
diff --git a/tests/channels/pjsip/refer_send_to_vm/test-config.yaml b/tests/channels/pjsip/refer_send_to_vm/test-config.yaml
index acbfe54..02e70bc 100644
--- a/tests/channels/pjsip/refer_send_to_vm/test-config.yaml
+++ b/tests/channels/pjsip/refer_send_to_vm/test-config.yaml
@@ -10,10 +10,16 @@
 properties:
     minversion: '12.2.0'
     dependencies:
-         - app : 'sipp'
-         - asterisk : 'res_pjsip'
-         - asterisk : 'res_pjsip_refer'
-         - asterisk : 'res_pjsip_send_to_voicemail'
+         - python: 'twisted'
+         - python: 'starpy'
+         - app: 'sipp'
+         - asterisk: 'app_dial'
+         - asterisk: 'app_userevent'
+         - asterisk: 'func_callerid'
+         - asterisk: 'res_pjsip'
+         - asterisk: 'res_pjsip_header_funcs'
+         - asterisk: 'res_pjsip_refer'
+         - asterisk: 'res_pjsip_send_to_voicemail'
     tags:
         - pjsip
 

-- 
To view, visit https://gerrit.asterisk.org/2333
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b113c33a1727851bfa6181b63018a4461904160
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>