[Asterisk-code-review] Update support for SILK format. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Thu Jun 30 16:56:01 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: Update support for SILK format.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/3136/2/res/res_format_attr_silk.c
File res/res_format_attr_silk.c:

Line 65: 	attr = ast_calloc(1, sizeof(*attr));
No need for ast_calloc() since attr_init() simply memsets the struct to zero which is what ast_calloc has just done.


Line 78: 	struct silk_attr *attr = ast_calloc(1, sizeof(*attr));
Same here about ast_calloc


-- 
To view, visit https://gerrit.asterisk.org/3136
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb39c95a9fecc9246bcfd3c45a6c9b51c59380e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list