[Asterisk-code-review] res pjsip: fix PJSIP tests to comply with ASTERISK-26061 (testsuite[master])
George Joseph
asteriskteam at digium.com
Wed Jun 29 12:29:42 CDT 2016
George Joseph has posted comments on this change.
Change subject: res_pjsip: fix PJSIP tests to comply with ASTERISK-26061
......................................................................
Patch Set 1:
> > Because these tests now depend on your changes, they're going to
> > fail on other branches like certified/13.1 and certified/13.8.
> > You'll need to add version-specific config sections with
> minversion
> > and maxversion.
> >
> > The original section would have a minversion of 13.0.0 and a
> > maxversion of 13.11.0 and your new section would have a
> minversion
> > of 13.11.0. There are other examples in tests/channels/pjsip.
>
> George,
> Please, carefully look at this patch.
> The patch doesn't add any dependency to these tests.
> This patch fixes the logical bugs.
>
> The 'Unknown' state is one of possible state for DeviceState,
> it has to be included.
>
> The peer status shouldn't be 'Unreachable' on startup.
> The status should be changed to 'Unreachable' if qualifying failed.
Ok, run the tests against certified/13.1 and certified/13.8 and report results.
--
To view, visit https://gerrit.asterisk.org/3091
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb824331c26b88d77e5b653efd51498bba039f04
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No
More information about the asterisk-code-review
mailing list