[Asterisk-code-review] sd notify (systemd status notifications) support (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: sd_notify (systemd status notifications) support
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Thanks for working on this.

General question to all: can we cherry-pick to 13?  This is low impact and adds a completely optional feature.

https://gerrit.asterisk.org/#/c/3094/1/include/asterisk/io.h
File include/asterisk/io.h:

Line 151: #define ast_sd_notify(state)   sd_notify(0, state)
Maybe better to create a real function instead?  This way modules would be able to use ast_sd_notify without linking to libsystemd.


https://gerrit.asterisk.org/#/c/3094/1/main/Makefile
File main/Makefile:

Line 48: ifeq ($(HAVE_SYSTEMD),1)
Isn't this ifeq unneeded?  I mean if we don't have systemd then $(SYSTEMD_LIB) should be blank.


https://gerrit.asterisk.org/#/c/3094/1/main/loader.c
File main/loader.c:

Line 908: 			ast_mutex_unlock(&reloadlock);
Need to sd_notify READY=1 before this unlock.


Line 927: 		ast_mutex_unlock(&reloadlock);
Need to sd_notify READY=1 before this unlock.


-- 
To view, visit https://gerrit.asterisk.org/3094
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied6a59dafd5ef331c5c7ae8f3ccd2dfc94be7811
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes