[Asterisk-code-review] codecs: Fix ABI incompatibility created by adding format na... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: codecs:  Fix ABI incompatibility created by adding format_name to ast_codec
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/3100/2/main/codec.c
File main/codec.c:

Line 63: 	struct ast_codec codec;
Suggest
strut ast_codec external;

Makes better member references:
codec->external.type
codec->external.id


Line 142: 	struct internal_ast_codec *internal_codec;
Should leave variable name as codec.  Then with the earlier internal_ast_codec name change you have:
codec->external.type

Instead of the odd looking references:
internal_codec->codec.type


Line 327: 	memcpy(&codec_new->codec, codec, sizeof(*codec));
Can go back to using the struct assignment as it is safer than hand coding a memcpy.

codec_new->codec = *codec;


-- 
To view, visit https://gerrit.asterisk.org/3100
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6df1b08f6a6ae089db23adfe1ebc8636330265ba
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes