[Asterisk-code-review] BuildSystem: Fix a few issues hightlighted by gcc 6.x (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Jun 28 11:44:01 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: BuildSystem:  Fix a few issues hightlighted by gcc 6.x
......................................................................


Patch Set 1:

(1 comment)

Minor nit

https://gerrit.asterisk.org/#/c/3095/1/channels/chan_unistim.c
File channels/chan_unistim.c:

PS1, Line 570: /* Not used but left for reference
             : static const unsigned char packet_send_CloseAudioStreamRX[] = { 0x16, 0x05, 0x31, 0x00, 0xff };
             : static const unsigned char packet_send_CloseAudioStreamTX[] = { 0x16, 0x05, 0x31, 0xff, 0x00 };
             : */
Rather than commenting these out, ifdef them out:

#ifdef NOT_DEFINED
#endif

Croma-coding will then still treat the lines as code instead of a comment.

The same as for the master version of the patch.


-- 
To view, visit https://gerrit.asterisk.org/3095
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6664d8f34a45bc1481d2a854481c7878b0c1cf8e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list