[Asterisk-code-review] siren: Add format attribute modules for Siren7 and Siren14. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: siren: Add format attribute modules for Siren7 and Siren14.
......................................................................


Patch Set 1:

Not sure if this is correct, therefore just a question:

PJSIP (its pjsua) allows/offers several other Siren bitrates, when I configure PJSIP via
CFLAGS='-DNDEBUG -DPJ_HAS_IPV6=1 -DPJMEDIA_HAS_G7221_CODEC=1 -DPJMEDIA_HAS_VIDEO=1' ./configure --prefix=/usr --enable-shared --with-external-srtp --with-external-speex --with-external-gsm --enable-libsamplerate --enable-epoll

You have to rise the codec priority in pjsua, to enable G.722.1 (Siren 7) and G.722.1C (Siren 14).

Did you test pjsua client against this change? I ask, because normally 'format_get_joint' is implemented and rejects offers which are incompatible. If I am not totally wrong, the old code ignored the whole offer not just the parameter. The current change accepts all Siren offers and might choose the wrong one at the end. If you like, I double-check this change with my test system.

By the way: Why does Digium support just one bitrate for each Siren?

-- 
To view, visit https://gerrit.asterisk.org/3089
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb004eda37a14c0a35ef0613f6237977fc800037
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No