[Asterisk-code-review] ari/resource channels: Add 'formats' to channel create/orig... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Thu Jun 23 17:15:17 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: ari/resource_channels:  Add 'formats' to channel create/originate
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2917/1/main/codec_builtin.c
File main/codec_builtin.c:

PS1, Line 777: 		codec.format_name = (codec).name; \
This broken the ABI compatibility for external codec modules.
Now asterisk crashed when loading external codec modules compiled for prev version.


-- 
To view, visit https://gerrit.asterisk.org/2917
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b23ecd41c1b4128d85028209772ee139f604b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list