[Asterisk-code-review] cdr adaptive odbc: Prevent not logger when is load before th... (asterisk[master])

Alexei Gradinari asteriskteam at digium.com
Thu Jun 23 15:28:54 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: cdr_adaptive_odbc: Prevent not logger when is load before than database.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2363/1/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 93: static int connected = 0;
This flag should be per connection, not global.
Think about a few connections to different DSNs.


-- 
To view, visit https://gerrit.asterisk.org/2363
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3569e29d26357055f440abf70f790cd12e874bf
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list