[Asterisk-code-review] res rtp asterisk: Enable Forward Secrecy (PFS) for DTLS. (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3068/1//COMMIT_MSG
Commit Message:

PS1, Line 16: STERISK-23905 #comment enabled PFS for DTLS as well
            : ASTERISK-25265 #comment enabled DHE based cipher suites as well
> I want to add a comment to those issues, because they belong to each other.
Integration between applications is never 100% so expecting a third party (Or even another Atlassian) application to update JIRA is not always going to work.  If you want to add a comment to the JIRA issue then you should put a comment in the JIRA issue yourself.  Your comment can then be more expressive than whatever you could do with the #comment action anyway.

Just referencing the JIRA issue (ASTERISK-xxxx) in the commit message will cause gerrit to indicate a hot-link to the issue.  I have noticed that using a period '.' after an issue reference tends to get the reference ignored by several applications (Including gerrit).

Re-opening an issue is a case-by-case judgement call because the fix could satisfy the reporter's complaint without fixing all related aspects of the feature.  You may be able to add issue related-to links to the JIRA issue yourself that you say this patch fixes (ASTERISK-25659).  At the very least a comment in the JIRA issue can reference other JIRA issues to create automatic hot links.

Since you have been fairly active in submitting patches, you should join IRC #asterisk-dev


-- 
To view, visit https://gerrit.asterisk.org/3068
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I537cadf4421f092a613146b230f2c0ee1be28d5c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes