[Asterisk-code-review] res rtp asterisk: Enable Forward Secrecy (PFS) for DTLS. (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/3068/1//COMMIT_MSG
Commit Message:

PS1, Line 16: STERISK-23905 #comment enabled PFS for DTLS as well
            : ASTERISK-25265 #comment enabled DHE based cipher suites as well
Please do not ever use the #comment action.

That action puts comments into the JIRA issue for EVERY commit.  Since this is going in v11, v13, and master there will be three identical comments added to the JIRA issue.


https://gerrit.asterisk.org/#/c/3068/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1317: 					long options = SSL_OP_CIPHER_SERVER_PREFERENCE | SSL_OP_SINGLE_DH_USE | SSL_OP_SINGLE_ECDH_USE;
wrap long line


-- 
To view, visit https://gerrit.asterisk.org/3068
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I537cadf4421f092a613146b230f2c0ee1be28d5c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes