[Asterisk-code-review] res pjsip: improve realtime performance #2 (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: improve realtime performance #2
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/2906/3/contrib/ast-db-manage/config/versions/ef7efc2d3964_ps_contacts_add_endpoint_and_modify_.py
File contrib/ast-db-manage/config/versions/ef7efc2d3964_ps_contacts_add_endpoint_and_modify_.py:

> Please make sure this works on postgres as well as mysql.  We just had to f
I've just successfully generated the SQL statements for MySQL and PostgreSQL.

====MySQL====
-- Running upgrade a845e4d8ade8 -> ef7efc2d3964
    
ALTER TABLE ps_contacts ADD COLUMN endpoint VARCHAR(40);
    
ALTER TABLE ps_contacts MODIFY expiration_time BIGINT NULL;
    
CREATE INDEX ps_contacts_qualifyfreq_exptime ON ps_contacts (qualify_frequency, expiration_time);
    
CREATE INDEX ps_aors_qualifyfreq_contact ON ps_aors (qualify_frequency, contact);
    
UPDATE alembic_version SET version_num='ef7efc2d3964' WHERE alembic_version.version_num = 'a845e4d8ade8';

====PostgreSQL====
-- Running upgrade a845e4d8ade8 -> ef7efc2d3964
    
ALTER TABLE ps_contacts ADD COLUMN endpoint VARCHAR(40);
    
ALTER TABLE ps_contacts ALTER COLUMN expiration_time TYPE BIGINT;
    
CREATE INDEX ps_contacts_qualifyfreq_exptime ON ps_contacts (qualify_frequency, expiration_time);
    
CREATE INDEX ps_aors_qualifyfreq_contact ON ps_aors (qualify_frequency, contact);
    
UPDATE alembic_version SET version_num='ef7efc2d3964' WHERE alembic_version.version_num = 'a845e4d8ade8';


https://gerrit.asterisk.org/#/c/2906/3/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

PS3, Line 249: 	/*! The name of the endpoint this contact belongs to */
             : 	AST_STRING_FIELD_EXTENDED(endpoint_name);
> has to be at the end of the structure.
Done


-- 
To view, visit https://gerrit.asterisk.org/2906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id324c1776fa55d3741e0c5457ecac0304cb1a0df
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes