[Asterisk-code-review] res pjsip session: Handle race condition at shutdown with ti... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_session: Handle race condition at shutdown with timer.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/3048/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 2671: 			int id = session_module.id;
> This probably need to be done throughout the routine.  As it is, we have al
Yes, but it's not actually used in the timer case since it's not running in the right thread. As well I believe the timer at shutdown is the only time this would happen, so I wanted to minimize the changes.


-- 
To view, visit https://gerrit.asterisk.org/3048
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88df72525c4e9ef9f19c13aedddd3ac4a335c573
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes