[Asterisk-code-review] res pjsip session: Handle race condition at shutdown with ti... (asterisk[13])
Richard Mudgett
asteriskteam at digium.com
Mon Jun 20 13:53:29 CDT 2016
Richard Mudgett has posted comments on this change.
Change subject: res_pjsip_session: Handle race condition at shutdown with timer.
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.asterisk.org/#/c/3048/1//COMMIT_MSG
Commit Message:
PS1, Line 21: This works as even though the module may be unregistered the ID when
: used on the INVITE session will still be valid.
awkward/run-on sentence
https://gerrit.asterisk.org/#/c/3048/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:
Line 2671: int id = session_module.id;
This probably need to be done throughout the routine. As it is, we have already checked the session pointer in the inv->mod_data[] at the beginning of the routine.
--
To view, visit https://gerrit.asterisk.org/3048
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88df72525c4e9ef9f19c13aedddd3ac4a335c573
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list