[Asterisk-code-review] fix: memory leaks, resource leaks, out of bounds and bugs (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: fix: memory leaks, resource leaks, out of bounds and bugs
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/3036/5/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

PS5, Line 422: 		tmp = strchr(ast_str_buffer(fmtp0), ':');
             : 		if (tmp && tmp[1] != '\0') {
             : 			fmtp1 = pj_str(tmp + 1);
             : 		} else {
             : 			fmtp1 = pj_str(ast_str_buffer(fmtp0));
             : 		}
             : 		attr = pjmedia_sdp_attr_create(pool, "fmtp", &fmtp1);
> This is not a finding against the patch itself but a comment about this par
I just corrected the incorrect code.
I think that the logic correction should be in a separate patch.


-- 
To view, visit https://gerrit.asterisk.org/3036
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbf7d0f360a021147344c4e83ab242fd1e7512c
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: ibercom <ibercom123 at gmail.com>
Gerrit-HasComments: Yes