[Asterisk-code-review] res pjsip pubsub: Address SEGV when attempting to terminate ... (asterisk[13])

Mark Michelson asteriskteam at digium.com
Fri Jun 17 10:42:50 CDT 2016


Mark Michelson has posted comments on this change.

Change subject: res_pjsip_pubsub: Address SEGV when attempting to terminate a subscription
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

Just a minor nitpick

https://gerrit.asterisk.org/#/c/3018/5/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 2264: static int isEvsubDestroyed(pjsip_evsub *evsub)
Coding guidelines: we don't take kindly to camelCase 'round these parts.


-- 
To view, visit https://gerrit.asterisk.org/3018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I779d11802cf672a51392e62a74a1216596075ba1
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list