[Asterisk-code-review] Testsuite: Fix SIP device state test ... again. (testsuite[master])

Mark Michelson asteriskteam at digium.com
Fri Jun 17 08:14:07 CDT 2016


Mark Michelson has uploaded a new patch set (#2).

Change subject: Testsuite: Fix SIP device state test ... again.
......................................................................

Testsuite: Fix SIP device state test ... again.

The previous fix to this test changed the timing of originations to be
when DeviceStateChange events were received. This works great as long as
the version of Asterisk being tested has that event. Asterisk versions
prior to 13 do not have this event.

The fix is to key off an event that is common to all versions of
Asterisk: ExtensionStatus. The logger message isn't as useful as it was
with DeviceStateChange, but the test now passes with all current
versions of Asterisk.

Change-Id: I040efcb4a2e64aa7e31143dbd626bb964f1a4025
---
M tests/channels/SIP/device_state_notification/originator.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/33/3033/2
-- 
To view, visit https://gerrit.asterisk.org/3033
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I040efcb4a2e64aa7e31143dbd626bb964f1a4025
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list