[Asterisk-code-review] ARI: Ensure announcer channels are destroyed. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Ensure announcer channels are destroyed.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/3023/2/res/ari/resource_bridges.c
File res/ari/resource_bridges.c:

Line 470: 	thread_data = ast_calloc(1, sizeof(*thread_data) + strlen(bridge->uniqueid) + 1);
An ast_malloc can be done here instead because all members are initialized below.


PS2, Line 482: 	if (ast_pthread_create_detached(&threadid, NULL, bridge_channel_control_thread, thread_data)) {
             : 		ast_ari_response_alloc_failed(response);
             : 		ast_free(thread_data);
             : 		return;
             : 	}
Need to do a stasis_app_bridge_playback_channel_remove on failure here.


-- 
To view, visit https://gerrit.asterisk.org/3023
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddc0f64484ea0016245800b409b567dfe85cfb4
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes